add ignore-compare-mode-next-solver to all next-solver tests - #163645
Merged
Merged
Conversation
rustbot
added
A-compiletest
lcnr
force-pushed
the
ui-tests-compare-mode
branch
7 times, most recently
from
October 2, 2026 10:44
891a0d5 to
167cc97
Compare
lcnr
marked this pull request as ready for review
October 2, 2026 10:45
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
lcnr
changed the title
ignore-compare-mode-next-solver to all next-solver tests
lcnr
force-pushed
the
ui-tests-compare-mode
branch
from
October 2, 2026 10:47
167cc97 to
11cfe15
Compare
Member
|
@bors r+ rollup=iffy |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
@bors rollup=iffy (had typo in previous comment that didn't get picked up - this touches a lot of tests) |
rust-bors
Bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
ui-tests-compare-mode
branch
from
October 3, 2026 08:27
11cfe15 to
5d332db
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=jackh726 rollup=iffy |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
…uwer Rollup of 8 pull requests Successful merges: - #163645 (add `ignore-compare-mode-next-solver` to all next-solver tests) - #163663 (reflection: fix ICE when TypeId::info called on ADT) - #163454 (Improve suggestion for lifetime preceding type in generics) - #163561 (tests: accept noundef in a couple more places) - #163633 (core: io: clean `unused_variables` lint under `no_io_statics`) - #163681 (Make the tracking issue template better suited for experiments) - #163685 (Avoid long iterator chain in all_rust_features) - #163690 (refactor: migrate to LLVM-C's `LLVMGetOrInsertFunction`) Failed merges: - #161491 (Rip out old solver coherence)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
Rollup merge of #163645 - lcnr:ui-tests-compare-mode, r=jackh726 add `ignore-compare-mode-next-solver` to all next-solver tests Adds `//@ ignore-compare-mode-next-solver (explicit revisions)` to all next-solver revision tests. Used an LLM to automate this and did a self-review. Can recommend only looking at `.rs` files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
//@ ignore-compare-mode-next-solver (explicit revisions)to all next-solver revision tests. Used an LLM to automate this and did a self-review. Can recommend only looking at.rsfiles.